Update Lingo LL1.yaml: MASTERY (Room Room) not require "gray" #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed MASTERY in Room Room (line 6939) to no longer require gray
hatkirby
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
I believe that, logically, these two requirements are identical. However, it is more semantically correct to require the panel instead of the color.
LGTM, with one minor request: please change it to require WALL (2) instead of 1, because 2 is the panel that's blocking the door.
changed WALL (1) to WALL (2)
NewSoupVi
added
is: refactor/cleanup
NewSoupVi
approved these changes
Feb 10, 2024
Berserker66
approved these changes
Feb 17, 2024
github-actions
bot
removed
the
waiting-on: core-review
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed MASTERY in Room Room (line 6939) to no longer require the "gray" item to solve.
Instead, it's kept out of logic by expecting the first gray WALL panel in Room Room to be solved first.