Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingo: Enable start_inventory_from_pool #2781

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

hatkirby
Copy link
Collaborator

What is this fixing or adding?

Enables start_inventory_from_pool option. get_filler_item_name is also implemented now. Filler items are distributed differently now; they are chosen at random instead of sequentially, which has no impact on gameplay as all filler items are no-ops.

How was this tested?

Test generation with a couple of different options.

If this makes graphical changes, please attach screenshots.

@hatkirby hatkirby marked this pull request as ready for review January 30, 2024 15:54
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did not do test generations, just reviewed the code.

@ScipioWright ScipioWright added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jan 30, 2024
@black-sliver black-sliver merged commit 3a51c03 into ArchipelagoMW:main Jan 31, 2024
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants