Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blasphemous: Remove poptracker pack from setup guide #2759

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

TRPG0
Copy link
Collaborator

@TRPG0 TRPG0 commented Jan 24, 2024

It doesn't work on the current version anymore.

@TRPG0 TRPG0 added the is: documentation Improvements or additions to documentation. label Jan 24, 2024
Copy link
Member

@NewSoupVi NewSoupVi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@PoryGone PoryGone added the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 10, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@black-sliver
Copy link
Member

It doesn't work on the current version anymore.

Can you explain? Is the AP rando now incompatible to the solo rando, or is the pack broken and unmaintained? Or is PopTracker broken and the pack doesn't work anymore?

@TRPG0
Copy link
Collaborator Author

TRPG0 commented Feb 29, 2024

Can you explain?

The poptracker pack was originally made to work with both Archipelago and standalone Blasphemous randomizer by making use of a websocket server, and since Blasphemous has to rely on c-wspp for WSS support, the websocket server doesn't work for multiworld anymore. It would technically still work in standalone Blasphemous randomizer, but Damocles decided to just cut it in favor of an in-game map tracker that he made instead, which is what we recommend people use instead now.

@black-sliver
Copy link
Member

Interesting. I am wondering if I should "fix" (i.e. make it more complete) c-wspp then. I never expected that to end up being used outside of what MultiClient asks from it.

@Exempt-Medic
Copy link
Member

It's also worth noting that, at this point, the PopTracker pack's logic is heavily outdated compared to both Blasphemous Randomizer and the AP Randomizer.

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation and I agree that it should be removed (for now at least; if it got replaced, probably forever).

@black-sliver black-sliver merged commit 7a85ee7 into ArchipelagoMW:main Feb 29, 2024
7 checks passed
@github-actions github-actions bot removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 29, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants