Mario & Luigi: Superstar Saga: Implement New Game #2754

jamesbrq · 2024-01-22T20:34:36Z

What is this fixing or adding?

Adds support for Mario & Luigi: Superstar Saga to AP.

How was this tested?

Months of testing over the course of many unsupported sync and async games.

If this makes graphical changes, please attach screenshots.

Silvris

Focused mostly on finding common pitfalls, big thing is definitely to move to the new options api since 0.4.4 will spew warnings at you until you do, and I imagine ideally we don't have any of those warnings in the next version.

worlds/mlss/Client.py

worlds/mlss/Options.py

worlds/mlss/Rules.py

worlds/mlss/__init__.py

worlds/mlss/docs/setup_en.md

Co-authored-by: Silvris <[email protected]>

… to World

worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md

Zunawe

Just looking at the client in isolation for now.

worlds/mlss/Client.py

worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md

Co-authored-by: Nicholas Saylor <[email protected]>

…Cleaned up Code

…into mlss

worlds/mlss/Regions.py

worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md

Co-authored-by: Nicholas Saylor <[email protected]>

Co-authored-by: Exempt-Medic <[email protected]>

…into mlss

jamesbrq · 2024-05-03T02:48:13Z

A 6 player sync was ran tonight, all players with 1 game of mlss, with all of the above changes from all PR reviews from the last few days. 2 small bugs we're found that were 1 liners on the asm side of things, and bugfixes were already applied to live branch. Everything else was perfectly fine and working as expected.

Exempt-Medic

Got through rules.py and everything looks good to me. That one error with the setup guide header should probably be addressed in some way, though that's probably a webhost error, so probably shouldn't be blocking, I think.

jamesbrq · 2024-05-04T21:22:19Z

Got through rules.py and everything looks good to me. That one error with the setup guide header should probably be addressed in some way, though that's probably a webhost error, so probably shouldn't be blocking, I think.

Worst case, I can temp change the & to just the word and. Whatever you think.

NewSoupVi · 2024-05-05T06:02:24Z

Looking into this Webhost issue to determine whether I consider it blocking for the merge.

worlds/mlss/Client.py

NewSoupVi · 2024-05-05T06:30:29Z

I've found the culprit for the Webhost issue:

#3269

I'll leave it up to you whether you want to separately implement a workaround for this issue, please let me know. But I am okay with this going in without a change.

jamesbrq · 2024-05-06T01:43:52Z

I've found the culprit for the Webhost issue:

#3269

I'll leave it up to you whether you want to separately implement a workaround for this issue, please let me know. But I am okay with this going in without a change.

Based on what I've seen in #3269 I'll be keeping the & in the title, since people are in agreeance that the PR provides the correct solution, and to keep the canonical name of the game.

NewSoupVi · 2024-05-06T07:14:08Z

worlds/mlss/Client.py

    eUsed: List[int]
+    room: int
+    local_events: List[int]


Small thing that I will let go because it's probably not an issue in practice:

This should probably be a set, because it's only used for lookup and sets have instant to logarithmic lookup

* Commit for PR * Commit for PR * Update worlds/mlss/Client.py Co-authored-by: Silvris <[email protected]> * Update worlds/mlss/__init__.py Co-authored-by: Silvris <[email protected]> * Update worlds/mlss/__init__.py Co-authored-by: Silvris <[email protected]> * Update worlds/mlss/docs/setup_en.md Co-authored-by: Silvris <[email protected]> * Remove deprecated import. Updated settings and romfile syntax * Updated Options to new system. Changed all references from MultiWorld to World * Changed switch statements to if else * Update en_Mario & Luigi Superstar Saga.md * Updated client.py * Update Client.py * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Nicholas Saylor <[email protected]> * Updated logic, Updated patch implementation, Removed unused imports, Cleaned up Code * Update __init__.py * Changed reference from world to mlssworld * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Nicholas Saylor <[email protected]> * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Nicholas Saylor <[email protected]> * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Nicholas Saylor <[email protected]> * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Nicholas Saylor <[email protected]> * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Nicholas Saylor <[email protected]> * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Nicholas Saylor <[email protected]> * Fix merge conflict + update prep * v1.2 * Leftover print commands * Update basepatch.bsdiff * Update basepatch.bsdiff * v1.3 * Update Rom.py * Change tracker locations to serverside, no longer locations. Various code cleanup and logic changes. * Event removal continuation. * Partial Implementation of APPP (Incomplete)) * v1.4 Implemented APPP * Docs Updated * Update Rom.py * Update setup_en.md * Update Rom.py * Update Rules.py * Fix for APPP being broken on webhost * Update Rom.py * Update Rom.py * Location name fixes + pants color fixes * Update Rules.py * Fix for ultra hammer cutscene * Fixed compat. issues with python ver. 3.8 * Updated hidden block yaml option * pre-v1.5 * Update Client.py * Update basepatch.bsdiff * v1.5 * Update XP multiplier to have a minimum of 0 * Update 'Beanfruit' to 'Bean Fruit' * v1.6 * Update Rom.py * Update basepatch.bsdiff * Initial review refactor * Revert state logic changes. Continuation of refactor. * Fixed failed generations. Finished refactor. * Reworked colors. Removed all .txt files * Actually removed the .txt files this time * Update Rom.py * Update README.md Co-authored-by: Exempt-Medic <[email protected]> * Update worlds/mlss/Options.py Co-authored-by: Exempt-Medic <[email protected]> * Update worlds/mlss/Client.py Co-authored-by: Exempt-Medic <[email protected]> * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Exempt-Medic <[email protected]> * Update worlds/mlss/__init__.py Co-authored-by: Exempt-Medic <[email protected]> * Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Co-authored-by: Exempt-Medic <[email protected]> * Update worlds/mlss/Data.py Co-authored-by: Exempt-Medic <[email protected]> * Review refactor. * Update README.md Co-authored-by: Exempt-Medic <[email protected]> * Update worlds/mlss/Rules.py Co-authored-by: Exempt-Medic <[email protected]> * Add coin blocks to LocationName * Refactor. * Update Items.py * Delete mlss.apworld * Small asm bugfix * Update basepatch.bsdiff * Client sends less messages to server * Update basepatch.bsdiff --------- Co-authored-by: Silvris <[email protected]> Co-authored-by: Nicholas Saylor <[email protected]> Co-authored-by: NewSoupVi <[email protected]> Co-authored-by: Exempt-Medic <[email protected]>

jamesbrq added 2 commits January 22, 2024 15:26

Commit for PR

77bb3c3

Commit for PR

d0e7d65

Silvris reviewed Jan 22, 2024

View reviewed changes

jamesbrq and others added 7 commits January 22, 2024 16:27

Update worlds/mlss/Client.py

b38968c

Co-authored-by: Silvris <[email protected]>

Update worlds/mlss/__init__.py

4234e81

Co-authored-by: Silvris <[email protected]>

Update worlds/mlss/__init__.py

e40f24b

Co-authored-by: Silvris <[email protected]>

Update worlds/mlss/docs/setup_en.md

a8792e1

Co-authored-by: Silvris <[email protected]>

Remove deprecated import. Updated settings and romfile syntax

0bbdae2

Updated Options to new system. Changed all references from MultiWorld…

b86d7ef

… to World

Changed switch statements to if else

94dcb26

ScootyPuffJr1 added the is: new game Pull requests for implementing new games into Archipelago. label Jan 23, 2024

Pixiuchu reviewed Jan 23, 2024

View reviewed changes

worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Outdated Show resolved Hide resolved

Update en_Mario & Luigi Superstar Saga.md

908c609

Zunawe reviewed Jan 23, 2024

View reviewed changes

jamesbrq added 2 commits January 23, 2024 18:16

Updated client.py

d9942ac

Update Client.py

aed0896

nicholassaylor suggested changes Jan 31, 2024

View reviewed changes

worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Outdated Show resolved Hide resolved

jamesbrq and others added 4 commits January 31, 2024 04:37

Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md

2ea54ce

Co-authored-by: Nicholas Saylor <[email protected]>

Merge branch 'main' into mlss

d97e66d

Updated logic, Updated patch implementation, Removed unused imports, …

5f2a75b

…Cleaned up Code

Merge branch 'mlss' of https://github.com/jamesbrq/ArchipelagoMainMLSS …

cd1e634

…into mlss

PoryGone added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 10, 2024

jamesbrq added 2 commits February 12, 2024 14:12

Update __init__.py

009cf45

Merge branch 'main' into mlss

ba9e953

ScipioWright reviewed Feb 18, 2024

View reviewed changes

worlds/mlss/Regions.py Outdated Show resolved Hide resolved

jamesbrq added 2 commits February 18, 2024 18:36

Changed reference from world to mlssworld

2614960

Merge branch 'main' into mlss

458fae4

nicholassaylor suggested changes Feb 24, 2024

View reviewed changes

worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md Outdated Show resolved Hide resolved

jamesbrq and others added 2 commits February 24, 2024 02:28

Update worlds/mlss/docs/en_Mario & Luigi Superstar Saga.md

fddad3b

Co-authored-by: Nicholas Saylor <[email protected]>

Merge branch 'main' into mlss

1ef8eef

jamesbrq and others added 9 commits May 2, 2024 16:03

Update worlds/mlss/Rules.py

6eb4b53

Co-authored-by: Exempt-Medic <[email protected]>

Add coin blocks to LocationName

6883b98

Refactor.

c072bd9

Merge branch 'main' into mlss

ddc9c45

Update Items.py

07385c8

Merge branch 'mlss' of https://github.com/jamesbrq/ArchipelagoMainMLSS …

227df52

…into mlss

Delete mlss.apworld

f9f6241

Small asm bugfix

ded8b73

Merge branch 'main' into mlss

f42dc0b

jamesbrq added 3 commits May 3, 2024 08:03

Merge branch 'main' into mlss

1f2c353

Merge branch 'main' into mlss

e010d71

Update basepatch.bsdiff

c3e4b57

Exempt-Medic approved these changes May 4, 2024

View reviewed changes

Merge branch 'main' into mlss

de68994

Zunawe reviewed May 5, 2024

View reviewed changes

worlds/mlss/Client.py Show resolved Hide resolved

Zunawe reviewed May 5, 2024

View reviewed changes

worlds/mlss/Client.py Outdated Show resolved Hide resolved

jamesbrq added 2 commits May 5, 2024 21:40

Client sends less messages to server

54f8ab1

Merge branch 'main' into mlss

99e3031

Update basepatch.bsdiff

da807d4

NewSoupVi approved these changes May 6, 2024

View reviewed changes

NewSoupVi merged commit 5935093 into ArchipelagoMW:main May 6, 2024
3 checks passed

jamesbrq deleted the mlss branch May 9, 2024 05:58

jamesbrq restored the mlss branch May 9, 2024 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mario & Luigi: Superstar Saga: Implement New Game #2754

Mario & Luigi: Superstar Saga: Implement New Game #2754

jamesbrq commented Jan 22, 2024

Silvris left a comment

Zunawe left a comment

jamesbrq commented May 3, 2024 •

edited

Loading

Exempt-Medic left a comment

jamesbrq commented May 4, 2024

NewSoupVi commented May 5, 2024

NewSoupVi commented May 5, 2024 •

edited

Loading

jamesbrq commented May 6, 2024

NewSoupVi May 6, 2024 •

edited

Loading

Mario & Luigi: Superstar Saga: Implement New Game #2754

Mario & Luigi: Superstar Saga: Implement New Game #2754

Conversation

jamesbrq commented Jan 22, 2024

What is this fixing or adding?

How was this tested?

If this makes graphical changes, please attach screenshots.

Silvris left a comment

Choose a reason for hiding this comment

Zunawe left a comment

Choose a reason for hiding this comment

jamesbrq commented May 3, 2024 • edited Loading

Exempt-Medic left a comment

Choose a reason for hiding this comment

jamesbrq commented May 4, 2024

NewSoupVi commented May 5, 2024

NewSoupVi commented May 5, 2024 • edited Loading

jamesbrq commented May 6, 2024

NewSoupVi May 6, 2024 • edited Loading

Choose a reason for hiding this comment

jamesbrq commented May 3, 2024 •

edited

Loading

NewSoupVi commented May 5, 2024 •

edited

Loading

NewSoupVi May 6, 2024 •

edited

Loading