Core: Default YAML header updates #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup
Added a "that" to remove an ambiguity
nicholassaylor
approved these changes
Jan 16, 2024
Combined the two sentences into one, per suggestion Co-authored-by: Nicholas Saylor <[email protected]>
Jarno458
added
is: maintenance
PoryGone
added
the
waiting-on: core-review
github-actions
bot
removed
the
waiting-on: core-review
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
* Cleaning up (ArchipelagoMW#4) Cleanup * Adressed change about spaces no longer being replaced to underscores. Added a "that" to remove an ambiguity * Update data/options.yaml Combined the two sentences into one, per suggestion Co-authored-by: Nicholas Saylor <[email protected]> --------- Co-authored-by: Nicholas Saylor <[email protected]>
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
* Cleaning up (ArchipelagoMW#4) Cleanup * Adressed change about spaces no longer being replaced to underscores. Added a "that" to remove an ambiguity * Update data/options.yaml Combined the two sentences into one, per suggestion Co-authored-by: Nicholas Saylor <[email protected]> --------- Co-authored-by: Nicholas Saylor <[email protected]>
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
* Cleaning up (#4) Cleanup * Adressed change about spaces no longer being replaced to underscores. Added a "that" to remove an ambiguity * Update data/options.yaml Combined the two sentences into one, per suggestion Co-authored-by: Nicholas Saylor <[email protected]> --------- Co-authored-by: Nicholas Saylor <[email protected]>
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
* Cleaning up (#4) Cleanup * Adressed change about spaces no longer being replaced to underscores. Added a "that" to remove an ambiguity * Update data/options.yaml Combined the two sentences into one, per suggestion Co-authored-by: Nicholas Saylor <[email protected]> --------- Co-authored-by: Nicholas Saylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Updating the default header of yamls to adress the fact spaces are no longer replaced to underscores.
How was this tested?
Reading