TUNIC: Change Tunic to TUNIC #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change would break existing yamls. So unless @silent-destroyer want's to absolutely do this, I would not recommend it. |
|
I have discussed this change with silent beforehand |
|
not only does this break the yamls but it also requires a client change |
alwaysintreble
added
the
is: refactor/cleanup
This also has been discussed with Silent |
|
I would like them to use the github feature to approve this PR then. |
silent-destroyer
approved these changes
Jan 17, 2024
Berserker66
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed init.py so that the name of the game appears as TUNIC instead of Tunic for uniformity.
How was this tested?
Ran WebHost locally