Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add FR guide for DLCQuest #2699

Merged
merged 11 commits into from
Jan 12, 2024

Conversation

deoxis9001
Copy link
Contributor

What is this fixing or adding?

Docs: add Translate FR guide for DLCQuest

How was this tested?

If this makes graphical changes, please attach screenshots.

@ScipioWright ScipioWright added the is: documentation Improvements or additions to documentation. label Jan 10, 2024
Copy link
Contributor

@ReverM ReverM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques petits détails ici et là mais très bien en grande partie.

J'aime la traduction "stock" pour le mot "pool"!

worlds/dlcquest/__init__.py Outdated Show resolved Hide resolved
worlds/dlcquest/docs/fr_DLCQuest.md Outdated Show resolved Hide resolved
worlds/dlcquest/docs/fr_DLCQuest.md Outdated Show resolved Hide resolved
worlds/dlcquest/docs/fr_DLCQuest.md Outdated Show resolved Hide resolved
worlds/dlcquest/docs/fr_DLCQuest.md Show resolved Hide resolved
worlds/dlcquest/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/dlcquest/docs/setup_fr.md Outdated Show resolved Hide resolved
worlds/dlcquest/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just forwarding the world maintainer approval

@black-sliver black-sliver changed the title Docs: add Translate FR guide for DLCQuest DLCQuest, Docs: add FR guide for DLCQuest Jan 11, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the original was properly formatted, i would suggest to properly format the new code as well

(Also sorry for renaming the PR twice. After changing it, I saw the amount of PRs and decided to be lazy and change it back to "Docs:")

worlds/dlcquest/__init__.py Outdated Show resolved Hide resolved
worlds/dlcquest/__init__.py Outdated Show resolved Hide resolved
@black-sliver black-sliver changed the title DLCQuest, Docs: add FR guide for DLCQuest Docs: add FR guide for DLCQuest Jan 11, 2024
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@black-sliver black-sliver merged commit b241644 into ArchipelagoMW:main Jan 12, 2024
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
* Docs: add Translate FR guide for DLCQuest

* Add Translate

* fix

* Update worlds/dlcquest/docs/fr_DLCQuest.md

Co-authored-by: Danaël V. <[email protected]>

* Fix Translate

* Fix translate

* Update __init__.py

* Update worlds/dlcquest/__init__.py

Co-authored-by: black-sliver <[email protected]>

* Update worlds/dlcquest/__init__.py

Co-authored-by: black-sliver <[email protected]>

---------

Co-authored-by: Danaël V. <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants