Muse Dash: Update song list to v3.12.0 and fix up a missing song #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix umpopoff not being included in songs by giving its only difficulty a value of 7. Fix warnings... Increase the max amount of songs now that we have 512 songs Fix syntax error that did not appear on my own repository. Add in filler items. Fix not adding a copy of the songs. Set duplicate songs to useful instead of progression Add placeholder for testing games. Revert "Merge branch 'Deamon/FillerItemsTry2' into Deamon/TouhouMugakudan3" This reverts commit 739a1a5, reversing changes made to 59a02ac.
DeamonHunter
added
the
is: enhancement
Berserker66
approved these changes
Jan 11, 2024
Berserker66
reviewed
Jan 11, 2024
| @@ -34,6 +34,7 @@ class MuseDashCollections: | |||
| "Rush-Hour", | |||
| "Find this Month's Featured Playlist", | |||
| "PeroPero in the Universe", | |||
| "umpopoff" | |||
There was a problem hiding this comment.
Suggested change
| "umpopoff" | |
| "umpopoff", |
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
- Adds all the songs from the Touhou Mugakudan -Ⅲ- update. - Increases the upper limit of additional songs to 508 due to there being 512 songs now. - Finally fixes umpopoff. As it was the only song that had less than 3 difficulties but also didn't have proper difficulty values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
How was this tested?
Tests. And double checked via debugging the umpopoff was now getting difficulty values.