Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Hat in Time: Implement New Game #2640

Merged
merged 176 commits into from
May 20, 2024
Merged

Conversation

CookieCat45
Copy link
Contributor

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

Adds A Hat in Time as a supported game in Archipelago.

How was this tested?

It's been continuously tested for almost a year at this point by me, friends, and people who downloaded and used the APWorld in their unsupported games. There was also a single public beta test in the Archipelago discord in October, which was mainly to test Online Party co-op, from which little to no issues arised.

If this makes graphical changes, please attach screenshots.

Annotation 2023-12-28 151843
image (1)
image

Copy link
Collaborator

@alwaysintreble alwaysintreble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only comment i have left is on the test. some more tests to check rules would also be good, but i don't think either of those are worth blocking. code lgtm

@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels May 17, 2024
@Berserker66 Berserker66 merged commit fe7bc87 into ArchipelagoMW:main May 20, 2024
16 checks passed
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
Adds A Hat in Time as a supported game in Archipelago.
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
Adds A Hat in Time as a supported game in Archipelago.
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Adds A Hat in Time as a supported game in Archipelago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: new game Pull requests for implementing new games into Archipelago. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants