The Witness: Cleanup - Options Access, data version, snake_case for file name #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NewSoupVi
commented
Dec 26, 2023
•
NewSoupVi
commented
- There were still some instances of not using the new options access, such as accessing start_inventory and local_items, which I did not know could be done through the new options system as well.
- Removed data_version
- Renamed "Options.py" to "options.py" to conform to the other files in the directory
NewSoupVi
added
the
is: refactor/cleanup
This was referenced Dec 26, 2023
Exempt-Medic
approved these changes
Jan 13, 2024
Berserker66
approved these changes
Jan 16, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.