-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update regarding new launcher #2627
Conversation
Added non-AP World specific information
Fixed broken link
Some minor touchups
Draft for version with picture
Small word change
Minor updates for conciseness, mostly
Sync contributing so I dont have to deal with it anymore
Removed part of several setup guides mentionning to tick the specific client Updated the setup for several game as you do not need to provide the rom during setup anymore.
Checksfinder and Undertale look fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm not the maintainer for any of these games, but looked over at least the games I'm familiar with (ALTTP, DKC3, LADX, OOT, and SMW) and the changes for those games look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve FFMQ section
Updated the main AP guide about AP installation to reflect launcher changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zillion section LGTM
a legally obtained ROM for that game as well. | ||
- The `Clients` are what are used to connect your game to the multiworld. Some games use a client that is automatically | ||
installed with an Archipelago installation. You can access those clients via the launcher or by navigating | ||
to your Archipelago installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a note that if they don't see a client, they will need to check the game page to learn how to set up the necessary connection to the multiworld
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose not to because I believe every player should check the respective setup guide.
i.e some games have a preinstalled client but still need a particular setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just a note directing them to always look at the game setup? most people seem to check those first anyway but it might be good to direct them here too. I guess I just don't trust people to look in the right spots. But it's not a point of contention. just a thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a link could be added in the connecting section
Adventure Minecraft and SMZ3 look fine - most of the changes are just removing the bit about checking the box, which is really all that needs to be done here, I think The update to actual generation feels good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve SM and SMZ3 changes.
I'm just going to take the executive decision to merge this so the website can get these updates since we're needing to update anyway. Edit: nevermind, i was too slow lol. still approving though. |
Uniformity tweak
Co-authored-by: Scipio Wright <[email protected]>
What is this fixing or adding?
Updating world docs wr/ to the launcher changes introduced in 0.4.4
More precisely, clients are automatically installed with AP (you don't need to tick them during installation) and thus, you do not need to provide the roms on installation, only during patching/generation.
How was this tested?
Reading
Here is a tasklist to keep track of which games need to be reviewed