The Witness: Fix Symmetry Island Upper Panel logic (2nd try) #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got lazy and didn't properly test the last fix. Big apologies, I got a bit panicked with all the logic errors that were being found.
NewSoupVi
added
the
is: bug/fix
Exempt-Medic
approved these changes
Dec 7, 2023
Berserker66
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2565 didn't actually fix what it was supposed to fix.
I got lazy and didn't properly test the last fix, I just tested that it doesn't break anything, but not whether it actually fixes the problem.
Big apologies, I got a bit panicked with all the logic errors that were being found inbetween being busy with other stuff. Not an excuse though.
This iteration is tested - Medic plandoed Colored Dots onto Symmetry Island Upper Panel and it didn't generate (which is correct)