Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiserver: data store datapackage #2561

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Berserker66
Copy link
Member

@Berserker66 Berserker66 commented Dec 4, 2023

What is this fixing or adding?

allows retrieval of datapackage via datastore read keys. In doing so allows retrieval of just checksum, just items, just locations and brings the existing just location name groups and just item name groups in line.
To make this usable ahead of Connected, uses #2562

How was this tested?

Not yet. Both testing and docs would be appreciated to be contributed.

If this makes graphical changes, please attach screenshots.

@Jarno458
Copy link
Collaborator

Jarno458 commented Dec 7, 2023

looking at the code i dont think it works as public_stored_data_keys dont have the _read_ prefix in them but they are compared on a 1 on 1 bases with what the client sends in all(key in ctx.public_stored_data_keys for key in args["keys"]):

@Jarno458 Jarno458 added affects: core Issues/PRs that touch core and may need additional validation. meta: help wanted Additional review/assistance is requested for these issues or pull requests. labels Dec 8, 2023
@PoryGone PoryGone added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 10, 2024
MultiServer.py Outdated Show resolved Hide resolved
Co-authored-by: Doug Hoskisson <[email protected]>
qwint added a commit to qwint/Archipelago that referenced this pull request Apr 12, 2024
…roups/location_groups commands to use them if connected

if connected but the groups cache does not exist it currently queries and prompts the user to retry but could be done pre auth if ArchipelagoMW#2561 is merged
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Apr 26, 2024
@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. meta: help wanted Additional review/assistance is requested for these issues or pull requests. waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants