-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiserver: data store datapackage #2561
Open
Berserker66
wants to merge
5
commits into
main
Choose a base branch
from
multiserver_data_store_datapackage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+40
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looking at the code i dont think it works as |
Jarno458
added
affects: core
Issues/PRs that touch core and may need additional validation.
meta: help wanted
Additional review/assistance is requested for these issues or pull requests.
labels
Dec 8, 2023
PoryGone
added
the
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
label
Feb 10, 2024
beauxq
reviewed
Apr 3, 2024
Co-authored-by: Doug Hoskisson <[email protected]>
qwint
added a commit
to qwint/Archipelago
that referenced
this pull request
Apr 12, 2024
…roups/location_groups commands to use them if connected if connected but the groups cache does not exist it currently queries and prompts the user to retry but could be done pre auth if ArchipelagoMW#2561 is merged
Exempt-Medic
added
the
is: enhancement
Issues requesting new features or pull requests implementing new features.
label
Apr 26, 2024
Exempt-Medic
added
the
waiting-on: author
Issue/PR is waiting for feedback or changes from its author.
label
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects: core
Issues/PRs that touch core and may need additional validation.
is: enhancement
Issues requesting new features or pull requests implementing new features.
meta: help wanted
Additional review/assistance is requested for these issues or pull requests.
waiting-on: author
Issue/PR is waiting for feedback or changes from its author.
waiting-on: peer-review
Issue/PR has not been reviewed by enough people yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
allows retrieval of datapackage via datastore read keys. In doing so allows retrieval of just checksum, just items, just locations and brings the existing just location name groups and just item name groups in line.
To make this usable ahead of Connected, uses #2562
How was this tested?
Not yet. Both testing and docs would be appreciated to be contributed.
If this makes graphical changes, please attach screenshots.