Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: Fix various incorrect symbol requirements in Vanilla Puzzles #2543

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Dec 1, 2023

You see this?
image

This is a 1-Shaper.

Now, you see this?
image

This is a *rotated 1-Shaper.

Totally different. :)

(This panel gets picked up by the client as "having Shapers" because this is technically a non rotated Shaper. The logic only has Rotated Shapers as a requirement for this panel. This means Shapers can be on this panel, creating an impossible seed. I could rotate this shaper client side, but since it's the "vanilla puzzles" mode, I don't want to make any changes to the puzzles, so...)

Edit: Medic found more of them. Thanks Medic!

Copy link
Collaborator

@hatkirby hatkirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks A-okay to me. Am I helping.

@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Dec 1, 2023
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, also tested them locally

@NewSoupVi NewSoupVi changed the title The Witness: Fix Caves First Floor Left logic in Vanilla Puzzles The Witness: Fix various incorrect symbol requirements in Vanilla Puzzles Dec 1, 2023
@Berserker66 Berserker66 merged commit a861ede into ArchipelagoMW:main Dec 4, 2023
7 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…zles (ArchipelagoMW#2543)

* Fix Vanilla First Floor Left

* More vanilla logic fixes

---------

Co-authored-by: Exempt-Medic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants