The Witness: Fix unreachable locations on certain settings (Keep PP2 EP, Theater Flowers EP) #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewSoupVi
added
the
is: bug/fix
|
I didn't actually fix the bug fully. Turning this back to draft |
|
Ok, well, I can't recreate any more problems, even though I could've sworn I still had an invalid gen. But even rerunning that same seed like 20 times didn't cause an issue. Gonna keep running random generations to see if I can hit any issues. Anyway, this definitely fixes something that badly needs fixing, and whatever other error I had, if it was real, is unrelated to this issue. So, ready for review again. |
NewSoupVi
changed the title
Berserker66
reviewed
Nov 25, 2023
Berserker66
reviewed
Nov 25, 2023
Co-authored-by: Fabian Dill <[email protected]>
Exempt-Medic
approved these changes
Nov 27, 2023
ScipioWright
added
affects: release/blocker
t3hf1gm3nt
added
the
affects: release/blocker
Berserker66
approved these changes
Dec 7, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…EP, Theater Flowers EP) (ArchipelagoMW#2499) Basically, the function for "checking entrances both ways" only checked one way. This resulted in unreachable locations. This affects Expert seeds with (non-remote doors and specific types of EP Shuffle), as well as seeds with non-remote doors + specific types of disabled panels + specific types of EP Shuffle. Also includes two changes that makes spoiler logs nicer (not creating unnecessary events).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the function for "checking entrances both ways" only checked one way. This resulted in unreachable locations.
This affects Expert seeds with (non-remote doors and specific types of EP Shuffle), as well as seeds with non-remote doors + specific types of disabled panels + specific types of EP Shuffle.
Also includes two changes that makes spoiler logs nicer (not creating unnecessary events).