Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options: set old options api before the world is created #2378

Merged
merged 9 commits into from
Dec 16, 2023
Merged

Options: set old options api before the world is created #2378

merged 9 commits into from
Dec 16, 2023

Commits on Oct 27, 2023

  1. Options: set old options api before the world is created

    @alwaysintreble
    alwaysintreble committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    2d63dd5 View commit details
    Browse the repository at this point in the history

  2. Options: deprecate old options API getting

    @alwaysintreble
    alwaysintreble committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    29a6f6a View commit details
    Browse the repository at this point in the history

  3. Options: deprecate option_definitions

    @alwaysintreble
    alwaysintreble committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    67b4f21 View commit details
    Browse the repository at this point in the history

  4. only print in __debug__ to not spam users

    @alwaysintreble
    alwaysintreble committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    24f16f3 View commit details
    Browse the repository at this point in the history

  5. properly assign values to the dict and don't assign to the same dict … 

    …multiple times for duplicate world types
    @alwaysintreble
    alwaysintreble committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    c5652f6 View commit details
    Browse the repository at this point in the history

  6. the optimization broke stuff

    @alwaysintreble
    alwaysintreble committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    9e599c8 View commit details
    Browse the repository at this point in the history

  7. import warning less often 

    Co-authored-by: black-sliver <[email protected]>
    @alwaysintreble @black-sliver
    alwaysintreble and black-sliver authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    1fa8cae View commit details
    Browse the repository at this point in the history

  8. only create each dict of the old system once

    @alwaysintreble
    alwaysintreble committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    396e4f0 View commit details
    Browse the repository at this point in the history

  9. add some typing for my sanity

    @alwaysintreble
    alwaysintreble committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    735eedb View commit details
    Browse the repository at this point in the history