-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiServer: make !hint without further arguments only reply to the instigating player #2339
Conversation
…nstigating player
@@ -649,7 +649,8 @@ def get_aliased_name(self, team: int, slot: int): | |||
else: | |||
return self.player_names[team, slot] | |||
|
|||
def notify_hints(self, team: int, hints: typing.List[NetUtils.Hint], only_new: bool = False): | |||
def notify_hints(self, team: int, hints: typing.List[NetUtils.Hint], only_new: bool = False, | |||
recipients: typing.Sequence[int] = None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this is be typing.Optional[typing.Sequence[int]] = None ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, = None is special cased as already implying Optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This special-casing has been removed and explicit Optional
is now recommended instead: python/peps@0630155
Out of scope feature request removed.
So yes I know there has been a lot of complaints about other players getting spammed when someone runs the basic !hint command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't recall if it was implemented at the time of my last comment, but now that we have the hint tab integrated into the client, my previous concerns have been solved by that tab. So I'm good with these changes now.
What is this fixing or adding?
Makes it so that !hint only lists the hints to the slot that send the command, not "spamming" anyone else.
I've heard complaints about this feature a few times, so hopefully this improves things.
Also left a note that this was changed to reduce potential player confusion.
How was this tested?
Barely, please test more.