Plando: Prevent duplicate candidate locations

[Silvris]

What is this fixing or adding?

https://discord.com/channels/731205301247803413/1161022518631608320/1161022518631608320
If a user specifies early_locations, non_early_locations, or manually puts the same location name multiple times in the locations field, plando can place items onto non-existent duplicate locations, leading to unfilled locations.

How was this tested?

Added the following plando to a default DS3 yaml, and generated alongside 2 LttP yamls.

  plando_items:
    - items:
        - Small Lothric Banner
        - Basin of Vows
      locations:
        - Mushroom
        - Mushroom
      from_pool: true
      world: true
      force: true

Checked that the issue was no longer present. It should be noted that in the case of specific duplication, it treats the length of the list as the number of unique locations.

If this makes graphical changes, please attach screenshots.

[black-sliver]

Thanks!

I still think we should rework how item plando is run under the hood when we have time since this had multiple issues now.

[black-sliver]

this actually seems to be the fastest way to drop duplicates in vanilla python.

[black-sliver]

Actually, I'm wondering if it's supposed to be more likely to hit a location if it's listed twice. Similar to weights.

[Berserker66]

Actually, I'm wondering if it's supposed to be more likely to hit a location if it's listed twice. Similar to weights.

As the one who originally wrote plando before it was expanded on, I'm relatively sure I did not have that intention.

[t3hf1gm3nt]

tested against the problem yamls/seed that was posted in the discord bug report, as well as a few more gens with different seeds. all genned successfully.

[black-sliver]

Merging as-is. I was leaving this open for berserker to have the final looksies since this is valuable for rolling the async.