Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA2B: v2.3 - The Chao Update #2277

Merged
merged 57 commits into from
Nov 16, 2023
Merged

Conversation

PoryGone
Copy link
Collaborator

@PoryGone PoryGone commented Oct 6, 2023

Changelog:

Features:

  • New goal
    • Chaos Chao
      • Raise a Chaos Chao to win!
  • New optional Location Checks
    • Chao Animal Parts
      • Each body part from each type of animal is a location
    • Chao Stats
      • 0-99 levels of each of the 7 Chao stats can be locations
      • The frequency of Chao Stat locations can be set (every level, every 2nd level, etc)
    • Kindergartensanity
      • Classroom lessons are locations
        • Either all lessons or any one of each category can be set as locations
    • Shopsanity
      • A specified number of locations can be placed in the Chao Black Market
      • These locations are unlocked by acquiring Chao Coins
      • Ring costs for these items can be adjusted
    • Chao Karate can now be set to one location per fight, instead of one per tournament
  • Items
    • If any Chao locations are active, the following will be in the item pool:
      • Chao Eggs
      • Garden Seeds
      • Garden Fruit
      • Chao Hats
      • Chaos Drives
  • The starting eggs in the garden can be a random color
  • Chao World entrances can be shuffled
  • Chao are given default names
  • New Traps
    • Reverse Trap

Quality of Life:

  • Chao Save Data is now separate per-slot in addition to per-seed
    • This allows a single player to have multiple slots in the same seed, each having separate Chao progress
  • Chao Race/Karate progress is now displayed on Stage Select (when hovering over Chao World)
  • All Chao can now enter the Hero and Dark races
  • Chao Karate difficulty can be set separately from Chao Race difficulty
  • Chao Aging can be sped up at will, up to 15×
  • New mod config option to fine-tune Chao Stat multiplication
    • Note: This does not mix well with the Mod Manager "Chao Stat Multiplier" code
  • Pong Traps can now activate in Chao World
  • Maximum range for possible number of Emblems is now 1000
  • General APWorld cleanup and optimization
    • Option access has moved to the new options system
    • An item group now exists for trap items

Bug Fixes:

  • Dry Lagoon now has all 11 Animals
  • Eternal Engine - 2 (Standard and Hard Logic) now requires only Tails - Booster
  • Lost Colony - 2 (Hard Logic) now requires no upgrades
  • Lost Colony - Animal 9 (Hard Logic) now requires either Eggman - Jet Engine or Eggman - Large Cannon

@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. labels Oct 17, 2023
worlds/sa2b/Items.py Outdated Show resolved Hide resolved
mission_count_table: typing.Dict[int, int] = {}

if multiworld.goal[player] == 3:
if world.options.goal == 3:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if world.options.goal == 3:
if world.options.goal == "grand_prix":

Are you aware you can write this? It's a bit easier to follow when one does not know that 3 happens to be grand prix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always been torn between the two. I'll make a note to reevaluate doing it this way on my next cleanup pass.

Copy link
Collaborator

@alwaysintreble alwaysintreble Oct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, could from .Options import Goal and then do world.options.goal == Goal.option_grand_prix if you want the typing which is how I prefer it.

Copy link
Member

@Berserker66 Berserker66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, left some optional hints for improvement.

@PoryGone
Copy link
Collaborator Author

We should probably hold off on merging this PR until after Berserker has successfully rolled the Big Async.

It shouldn't™️ cause generation failures or anything with old yamls, but some options were renamed, so anyone that had turned on Chao stuff wouldn't have that actually rolled, using an old yaml with this update.

@Berserker66 Berserker66 merged commit 85d02b2 into ArchipelagoMW:main Nov 16, 2023
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Changelog:

Features:
- New goal
  - Chaos Chao
    - Raise a Chaos Chao to win!
- New optional Location Checks
  - Chao Animal Parts
    - Each body part from each type of animal is a location
  - Chao Stats
    - 0-99 levels of each of the 7 Chao stats can be locations
    - The frequency of Chao Stat locations can be set (every level, every 2nd level, etc)
  - Kindergartensanity
    - Classroom lessons are locations
      - Either all lessons or any one of each category can be set as locations
  - Shopsanity
    - A specified number of locations can be placed in the Chao Black Market
    - These locations are unlocked by acquiring `Chao Coin`s
    - Ring costs for these items can be adjusted 
  - Chao Karate can now be set to one location per fight, instead of one per tournament
- Items
  - If any Chao locations are active, the following will be in the item pool:
    - Chao Eggs
    - Garden Seeds
    - Garden Fruit
    - Chao Hats
    - Chaos Drives
- The starting eggs in the garden can be a random color
- Chao World entrances can be shuffled
- Chao are given default names
- New Traps
  - Reverse Trap

Quality of Life:
- Chao Save Data is now separate per-slot in addition to per-seed
  - This allows a single player to have multiple slots in the same seed, each having separate Chao progress
- Chao Race/Karate progress is now displayed on Stage Select (when hovering over Chao World)
- All Chao can now enter the Hero and Dark races
- Chao Karate difficulty can be set separately from Chao Race difficulty
- Chao Aging can be sped up at will, up to 15×
- New mod `config` option to fine-tune Chao Stat multiplication
  - Note: This does not mix well with the Mod Manager "`Chao Stat Multiplier`" code
- Pong Traps can now activate in Chao World
- Maximum range for possible number of Emblems is now 1000
- General APWorld cleanup and optimization
  - Option access has moved to the new options system
  - An item group now exists for trap items

Bug Fixes:
- Dry Lagoon now has all 11 Animals
- Eternal Engine - 2 (Standard and Hard Logic) now requires only `Tails - Booster`
- Lost Colony - 2 (Hard Logic) now requires no upgrades
- Lost Colony - Animal 9 (Hard Logic) now requires either `Eggman - Jet Engine` or `Eggman - Large Cannon`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants