-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUNIC: Implement New Game #2172
Merged
Berserker66
merged 108 commits into
ArchipelagoMW:main
from
silent-destroyer:tunic-randomizer
Jan 12, 2024
Merged
TUNIC: Implement New Game #2172
Berserker66
merged 108 commits into
ArchipelagoMW:main
from
silent-destroyer:tunic-randomizer
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage, but importantly it does generate now
Some fixes to get it to generate, and some little formatting things
…tunic doc to pass unit tests
CSV usage fix for apworld compatibility
… think others would be necessary?
Location and Item name grouping
Some changes to docs, some might be a little nitpicky
Added more location groups, and a default group as the region name
ThePhar
added
the
is: new game
Pull requests for implementing new games into Archipelago.
label
Oct 16, 2023
el-u
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna give this one a checkmark with the following caveats:
- I never played this game; just looked at the code
- Test coverage is sparse
- World code does not fully conform to AP code style (many lines go over 120)
el-u
reviewed
Nov 26, 2023
Merging the entrance rando feature here now so that it can be reviewed and included in the initial tunic merge. |
* Update en_Tunic.md
* ER now uses events rather than a series of can_reach's. Slightly slower gen, better spoiler output. * Adds an option to specifically place Laurels at either 6 coins, 10 coins, or 10 fairies. * Logic options - Restricted, NMG, Unrestricted * Maskless option (so that NMG and Unrestricted don't specifically imply maskless) * Lanternless option (so that NMG and Unrestricted don't specifically imply lanternless)
Berserker66
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Adds Archipelago support for the game TUNIC.
The client mod can be found here: https://github.com/silent-destroyer/tunic-randomizer-archipelago
How was this tested?
Several test sessions among members of the community, and continuous updates to the apworld and client based on feedback/bug reports.
If this makes graphical changes, please attach screenshots.