-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muse Dash: Fix bad generations occuring due to changing item ids #2122
Muse Dash: Fix bad generations occuring due to changing item ids #2122
Conversation
…use issues if it was.
"Nyaa SFX Trap": 8, | ||
"Error SFX Trap": 9, | ||
"Nyaa SFX Trap": STARTING_CODE + 8, | ||
"Error SFX Trap": STARTING_CODE + 9, | ||
} | ||
|
||
item_names_to_id = ChainMap({}, sfx_trap_items, vfx_trap_items) | ||
location_names_to_id = ChainMap(song_locations, album_locations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The World
API defines both item_name_to_id
and location_name_to_id
as a ClassVar[Dict[str, int]]
, not a ChainMap
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the MuseDashWorld part into a dictionary, but kept this as a chainmap. Hopefully should be good.
What is this fixing or adding?
This PR adjusts the MuseDashCollection class to be a bit more hardcoded, and resolve some issues where running it multiple times could cause Ids to change. (Test added to ensure this isn't the case anymore)
Additionally:
code: None
into the pool.Budget Is Burning Vol.1
to not show.How was this tested?
Several local generations + tests.
If this makes graphical changes, please attach screenshots.
N/A