Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LADX: Text shuffle #2051

Merged
merged 8 commits into from
Nov 22, 2023
Merged

LADX: Text shuffle #2051

merged 8 commits into from
Nov 22, 2023

Conversation

zig-for
Copy link
Collaborator

@zig-for zig-for commented Jul 29, 2023 •
edited
Loading

What is this fixing or adding?

Adds text shuffle to the LADX

How was this tested?

  • Locally, with yaml option on and off
  • Sent off to the discord channel for further testing
NinTheFolf — 07/28/2023 8:36 PM
everything seems good. though the optional items (trade items, maps, compasses, beaks) don't seem to have their text shuffled.

If this makes graphical changes, please attach screenshots.

image

@ThePhar
Copy link
Member

ThePhar commented Jul 29, 2023 •
edited
Loading

Why create a PR if there's no description or details?

If possible, do not create a PR for a world if it's not ready for review or it doesn't need to be worked with other developers during development.

Better to leave it as a branch on your fork until then.

@ThePhar ThePhar added meta: needs more info Issues or pull requests that needs more information before it can be actioned. is: enhancement Issues requesting new features or pull requests implementing new features. and removed meta: needs more info Issues or pull requests that needs more information before it can be actioned. labels Jul 29, 2023
@zig-for zig-for marked this pull request as ready for review August 11, 2023 04:29
@ThePhar ThePhar merged commit 01b566b into ArchipelagoMW:main Nov 22, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@zig-for @Jouramie
LADX: Text shuffle (ArchipelagoMW#2051)
bc486a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePhar ThePhar ThePhar approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zig-for @ThePhar