LADX: Fix hints crash #2050
Merged
LADX: Fix hints crash #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
the
is: bug/fix
|
If a game has unplaced items it's technically a bug for the world that created extra items. |
|
What's going on here? It looks like the PR consists of a 1-line change to work around a crash and then 99 other lines to introduce a (completely unrelated?) new option. |
The log posted in https://discord.com/channels/731205301247803413/1134521806099853352 reports neither unplaced items nor unfilled locations. |
|
I forked off of a feature branch by accident |
zig-for
force-pushed
the
zig/ladx/hints_crash
branch
from
b344ac8
to
0cde895
Compare
|
Fixed |
Berserker66
approved these changes
Jul 29, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
kl3cks7r
pushed a commit
to kl3cks7r/Archipelago
that referenced
this pull request
Dec 15, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes the crash - TIL unplaced items are normal.