-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undertale: Key placement fix #2030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed documentation on RandomizeLove and RandomizeStats to be less confusing about if they will work with all routes. Added the ability to press W to warp to the hub from any savepoint.
…being read from a text file when it shouldn't. Also added more info to the docs about gameplay differences.
…he starting key an automatically sent check that is forced to be a key, that way it can be plando'd.
…set starting key instead. Changed the button items to be useful instead of progression. Removed the unused rules for the button items.
ThePhar
added
is: bug/fix
Issues that are reporting bugs or pull requests that are fixing bugs.
affects: release/blocker
Issues/PRs that must be addressed before next official release.
labels
Jul 24, 2023
Adding blocker label since current RC1 causes high failure rate for UT with multiple players. |
Berserker66
reviewed
Jul 24, 2023
Co-authored-by: Fabian Dill <[email protected]>
Co-authored-by: Aaron Wagener <[email protected]>
ThePhar
requested changes
Jul 25, 2023
…item. Added a yaml option to choose starting key
Co-authored-by: Aaron Wagener <[email protected]>
el-u
reviewed
Jul 28, 2023
Co-authored-by: el-u <[email protected]>
Berserker66
approved these changes
Jul 30, 2023
el-u
approved these changes
Aug 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR solves the issue that there was a high probability of FillError
in Undertale generations.
ThePhar
approved these changes
Aug 16, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Co-authored-by: Fabian Dill <[email protected]> Co-authored-by: Aaron Wagener <[email protected]> Co-authored-by: el-u <[email protected]>
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Co-authored-by: Fabian Dill <[email protected]> Co-authored-by: Aaron Wagener <[email protected]> Co-authored-by: el-u <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects: release/blocker
Issues/PRs that must be addressed before next official release.
is: bug/fix
Issues that are reporting bugs or pull requests that are fixing bugs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
Fixed it waiting to fill the Starting Key check, because that check requires one of four items to be placed on it.
How was this tested?
Repeatedly generating with and without plando.
If this makes graphical changes, please attach screenshots.