HK: Fix bugs and update setup guide for Scarab+ and XBox Game Pass support #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed wording for items accessibility to describe how it actually works. Reordered settings such as local_items and start_location_hints to match their order in templates. Fixed some grammatical errors.
Co-authored-by: Zach Parks <[email protected]>
Moved `accessibility`, `progression_balancing`, and `triggers` to game sections instead of root sections and reworded description accordingly. Updated version number. Fixed `progression_balancing` values in example YAMLs.
ThePhar
added
is: bug/fix
remyjette
reviewed
Jul 7, 2023
BadMagic100
suggested changes
Jul 7, 2023
BadMagic100
approved these changes
Jul 8, 2023
Berserker66
approved these changes
Jul 11, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…pport (ArchipelagoMW#1955) Fixing three bugs: 1. Made Salubra Charm Shop Slots use the actual options value and not the Iselda Shop Slots value. 2. Made Mask Shards no longer considered Filler but instead Progression so they can actually be used for access requirements that require damage boosts. 3. Fixed goal requirements to account for Focus being required for The Hollow Knight and Sealed Siblings endings and adjusted the Radiance and Any goal requirements accordingly. Updated Setup Guide: Changed to mention Scarab+ instead of Scarab (it is better maintained and has several quality of life improvements and fixes a bug for XBox Game Pass). Added info about how to use Scarab+ with XBox Game Pass.
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…pport (ArchipelagoMW#1955) Fixing three bugs: 1. Made Salubra Charm Shop Slots use the actual options value and not the Iselda Shop Slots value. 2. Made Mask Shards no longer considered Filler but instead Progression so they can actually be used for access requirements that require damage boosts. 3. Fixed goal requirements to account for Focus being required for The Hollow Knight and Sealed Siblings endings and adjusted the Radiance and Any goal requirements accordingly. Updated Setup Guide: Changed to mention Scarab+ instead of Scarab (it is better maintained and has several quality of life improvements and fixes a bug for XBox Game Pass). Added info about how to use Scarab+ with XBox Game Pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixing three bugs:
Updated Setup Guide:
Changed to mention Scarab+ instead of Scarab (it is better maintained and has several quality of life improvements and fixes a bug for XBox Game Pass).
Added info about how to use Scarab+ with XBox Game Pass.
How was this tested?
Around 100 generation with various setting combinations and plando options to test whether seeds registered properly as (un)beatable and checked whether spoiler logs required the proper items.