Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM: save and quit escape restriction and bad EscapeTrigger code fix #1929

Merged
merged 222 commits into from
Jul 3, 2023

Conversation

lordlou
Copy link
Contributor

@lordlou lordlou commented Jul 2, 2023

What is this fixing or adding?

How was this tested?

Generated 2 single player SM (one with Disabled Tourian and no Objective, and another with Default Tourian and no Objective) to verify that using L+R+Select+Start is disabled when the Escape Timer event is set and that its still permitted otherwise.

Generated a single player SM with Disabled Tourian and no Objective, successfully with the fix, but was getting exception before.

…VariaRandomizer's rules, items, locations and accessPoint (as regions)
…se (fills ROM item table)

This is dependant on modifications done to sm_randomizer_rom project
- player name inject in ROM and get in client
- end game get from ROM in client
- send self item to server
- add player names table in ROM
…ition of an array of it (required to generation more than one SM world, which is still fails but is better)
- fixed seeded generation
- fixed broken logic when more than one SM world
- added missing rules for inter-area transitions
- added basic patch presence for logic
- added DoorManager init call to reflect present patches for logic
- moved CollectionState addition out of BaseClasses into SM world
- added condition to apply progitempool presorting only if SM world is present
- set Bosses item id to None to prevent them going into multidata
- now use get_game_players
…VariaRandomizer's rules, items, locations and accessPoint (as regions)
…se (fills ROM item table)

This is dependant on modifications done to sm_randomizer_rom project
- player name inject in ROM and get in client
- end game get from ROM in client
- send self item to server
- add player names table in ROM
…ition of an array of it (required to generation more than one SM world, which is still fails but is better)
fixed wrong code when EscapeTrigger is required (X.item.advancement isnt defined for ItemLocation)
@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jul 2, 2023
@ThePhar ThePhar merged commit b077b2a into ArchipelagoMW:main Jul 3, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…rchipelagoMW#1929)

* prevent using save and reload when escaping Zebes

fixed wrong code when EscapeTrigger is required (X.item.advancement isnt defined for ItemLocation)
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…rchipelagoMW#1929)

* prevent using save and reload when escaping Zebes

fixed wrong code when EscapeTrigger is required (X.item.advancement isnt defined for ItemLocation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants