Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: add freeze_support, Launcher: use spawn #1890

Merged

Conversation

black-sliver
Copy link
Member

What is this fixing or adding?

  • use "spawn" to launch multiprocessing from Launcher - this is default on Windows, but has to be set explicitly on Linux and mac since the default "fork" breaks kivy
  • implement the windows-exclusive freeze_support fix for non-windows to allow "spawn" to work on non-windows - this is a very old bug in upstream python

How was this tested?

by launching bfbb client and factorio client on Linux via multiprocessing in a frozen build

@black-sliver black-sliver merged commit a96ff8d into ArchipelagoMW:main Jun 25, 2023
@black-sliver black-sliver deleted the launcher-linux-freeze-fix branch June 25, 2023 00:24
@ThePhar ThePhar added the is: enhancement Issues requesting new features or pull requests implementing new features. label Jun 25, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants