Core: Minimal-Items Accessibility Fix

[Alchav]

What is this fixing or adding?

The promises of locations accessibility ensuring "everything can be reached and acquired" and items accessibility ensuring "all logically relevant items can be acquired" imply that an items player may have locations they cannot reach, but that their own advancement items will always be reachable.

This is largely what the accessibility check ensures, except that if an items player has locations that are not reachable, a minimal players' unnecessary advancement items may be placed in the items player's unreachable locations and this will cause the accessibility check to fail.

Currently the Dexsanity option in Pokémon Red and Blue allows for logically inaccessible locations. In some cases they may be locations that you can in fact reach or that you may have to make a specific choice in order to reach, but need to be out of logic because it may be possible to permanently miss them. Right now this option forces accessibility off of locations (unless other options are set specifically that will prevent any from being out of logic) but in my WIP update, I am instead deleting the unreachable locations if locations accessibility is chosen.

This PR tweaks the accessibility check to allow items players' locations to contain minimal players' advancement items

How was this tested?

After seeing an accessibility check failure due to a minimal player's advancement item landing on an inaccessible items player's location, re-generated with same seed using this change.

[ThePhar]

Got an example yaml I can get it to reproduce? I can try to run through this later.

[Alchav]

Got an example yaml I can get it to reproduce? I can try to run through this later.

With --seed 1

name: a
game: Pokemon Red and Blue
Pokemon Red and Blue:
  accessibility: minimal
  progression_balancing: disabled
  start_inventory: {HM03 Surf: 1, HM04 Strength: 1, Soul Badge: 1, Rainbow Badge: 1}
  badgesanity: on
  elite_four_condition: 0
  victory_road_condition: 0
---
name: b
game: Pokemon Red and Blue
Pokemon Red and Blue:
  accessibility: items
  progression_balancing: disabled
  start_inventory: {HM03 Surf: 1, HM04 Strength: 1, Soul Badge: 1, Rainbow Badge: 1}
  badgesanity: on
  elite_four_condition: 0
  victory_road_condition: 0
  dexsanity: on