SC2: Python 3.11 compatibility #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziktofel
changed the title
|
According to @Them8 everything looks OK ingame |
|
The bot folder should probably have at least a readme, detailing what it is, where it's from and where the documentation is. |
|
done |
|
ModuleNotFoundError: No module named 'loguru' |
|
hm, weird
I'll dig into that later |
|
It is in the subfolder's requirements.txt, however ModuleUpdate doesn't look that deep. |
Move the bot's requirements file to _sc2common root directory
|
Merged the Salz's fix for that |
ThePhar
added
the
is: bug/fix
Berserker66
approved these changes
Jun 12, 2023
Witchybun
pushed a commit
to Witchybun/Archipelago
that referenced
this pull request
Jun 26, 2023
Co-authored-by: Salzkorn
kindasneaki
pushed a commit
to kindasneaki/Archipelago
that referenced
this pull request
Jun 28, 2023
Co-authored-by: Salzkorn
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Co-authored-by: Salzkorn
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Co-authored-by: Salzkorn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
SC2 Client Python 3.11 compatibility
How was this tested?
The game launches
If this makes graphical changes, please attach screenshots.
No