WebHost: add game to template export #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested. This only works for the simple settings pages but template already has the game in the description and weighted settings game is usually unknown so LGTM |
black-sliver
approved these changes
May 20, 2023
remyjette
added a commit
to remyjette/Archipelago
that referenced
this pull request
Jan 9, 2024
ArchipelagoMW#1820 added the game name to template export, but when ArchipelagoMW#2143 began overriding the description in Javascript to name the preset it removed the game name. Also while I was here I figured we might as well not hardcode https://archipelago.gg, since it can be useful to know if a YAML was generated by some other Web Host (for example http://archipelago.gg:24242 if coming from the beta site)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
adds game name to yaml description
https://discord.com/channels/731205301247803413/1096951081034072124/1096951081034072124
How was this tested?
by exporting and looking
If this makes graphical changes, please attach screenshots.