-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Revise all docs mentioning Lua in EmuHawk (which are in English), and other misc. corrections #1782
Conversation
in strings and camelCase identifiers
Thanks for the PR! Re duplication/jinja. Markdown was a deliberate choice back in the day and it allows modification by less tech-savvy people. Jinja requires a local webhost while markdown can be pasted into a live preview and rendered on github. Can you maybe elaborate here on where to use "EmuHawk" and where to use "BizHawk"? I would prefer to put "BizHawk" everywhere to avoid confusion, but if this is incorrect, I'd like to know exactly why. |
By the way
reads to me the same as your #NotOurProblem tag, which reads like F U. If you don't think it's necessary to post a screenshot, just don't. |
I cannot; we don't have branding guidelines yet. At this stage it's a personal vendetta of mine against phrases like "open the rom in BizHawk", which are technically ambiguous when we ship 2 apps, possibly more in the future. I've put that commit at the end so you can easily drop it.
I'm aware of this, I just haven't gotten to it yet. There are also inconsistencies in the BizHawk codebase.
My apologies. And thank you for reminding me of that label, I agree it needs improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. most of it being BizHawk Capitalization and changing references to use EmuHawk . Other big change preferring the user to drag and drop the script instead of loading through the BizHawk file picker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While i think the capitalization and references to EmuHawk are unecessary, I'm not gonna argue with one of the BizHawk devs about that. The rest of the changes to the guide are what I'm approving and desire to have added, as it adds the second method of loading scripts and, more importantly IMO, adds an update we forgot to do when we added support for 2.9+ about the lua core switching only being required in older BizHawk versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes render correctly on webhost. This was posted to our Discord for public review and no concerns were raised. Relaying the approval of shananas and figment (I personally don't use BizHawk) and merging before we get more conflicts.
…), and other misc. corrections (ArchipelagoMW#1782) * Fix links to TASVideos.org using HTTP * Revise all docs mentioning Lua in EmuHawk which are in English resolves TASEmulators/BizHawk#3650 * Correct capitalisation of "BizHawk" in strings and camelCase identifiers * Use the term "EmuHawk" when referring to the app, in English docs --------- Co-authored-by: black-sliver <[email protected]>
…), and other misc. corrections (ArchipelagoMW#1782) * Fix links to TASVideos.org using HTTP * Revise all docs mentioning Lua in EmuHawk which are in English resolves TASEmulators/BizHawk#3650 * Correct capitalisation of "BizHawk" in strings and camelCase identifiers * Use the term "EmuHawk" when referring to the app, in English docs --------- Co-authored-by: black-sliver <[email protected]>
…), and other misc. corrections (ArchipelagoMW#1782) * Fix links to TASVideos.org using HTTP * Revise all docs mentioning Lua in EmuHawk which are in English resolves TASEmulators/BizHawk#3650 * Correct capitalisation of "BizHawk" in strings and camelCase identifiers * Use the term "EmuHawk" when referring to the app, in English docs --------- Co-authored-by: black-sliver <[email protected]>
What is this fixing or adding?
http://tasvideos.org
,*.html
).How was this tested?
N/A (URIs and error messages were untouched, identifiers were replaced across the whole codebase).