-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorio: flatten science pack curve #1660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the old factorio_id
now be refactored to _factorio_tech_id
to avoid further confusion?
now contains changes for @alwaysintreble to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do any testing but code changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gen works, have not tried loading an actual seed though. I trust you did that?
Anyway, only found 1 more minor detail, see below
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Co-authored-by: black-sliver <[email protected]>
What is this fixing or adding?
instead of 255, 127, 85 etc. Locations for the respective science packs, the pools are now a clean 255, 255, 255 etc.
When selecting Locations for the generation, this means a roughly equal amount of Locations per highest pack.
Raising min Client version to 0.4.0, while technically not required, it does prevent a confused client if:
0.3.8 Client connects to 0.4.1 Multiworld, then connects to a 0.4.0 or 0.3.8 Multiworld where IDs are changed but checksum is not yet in place.
How was this tested?
I looked at a spoiler log.