Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward missed CancellationTokens #459

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Forward missed CancellationTokens #459

merged 1 commit into from
Jan 16, 2023

Conversation

iwedaz
Copy link

@iwedaz iwedaz commented Jan 8, 2023

Forward missed CancellationTokens from API to IApiClientTransport calls

DiscoPYF
DiscoPYF approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Thanks @iwedaz 👍

How did you spot these? Did you use any tools? I'm asking in case we can learn something to avoid this in future.

@DiscoPYF DiscoPYF merged commit ebaf170 into ArangoDB-Community:master Jan 16, 2023
@iwedaz iwedaz deleted the iwedaz/cancellation_tokens branch February 14, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiscoPYF DiscoPYF DiscoPYF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwedaz @DiscoPYF @ilya-murashko-leverx