Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test-arangodb-3_10 in CircleCI workflow. #430

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Added test-arangodb-3_10 in CircleCI workflow. #430

merged 2 commits into from
Oct 17, 2022

Conversation

tjoubert
Copy link
Contributor

Added test-arangodb-3_10 in CircleCI workflow.

@tjoubert tjoubert changed the title AdAdded test-arangodb-3_10 in CircleCI workflow. Added test-arangodb-3_10 in CircleCI workflow. Oct 15, 2022
@tjoubert
Added version to all test fixture classes and fixed GraphApiClientTes…
cac86b1 
…t.PostVertexAsync_ShouldThrow_WhenVertexCollectionIsNotFound()
@tjoubert
Copy link
Contributor Author

tjoubert commented Oct 15, 2022 •
edited
Loading

GraphApiClientTest.PostVertexAsync_ShouldThrow_WhenVertexCollectionIsNotFound() was failing tests on line 437 because in ArangoDB 3.10, the error number is 1947 (not 1203). So there was a need to check for the version number on this specific line.
I've added support for version numbers to all test fixture classes. I think it gives us a bit more control on version-specific processing than the Trait attribute does. What do you think @DiscoPYF? That said, I think it's good we keep both in place; we'll use if statements to check version numbers within functions and the Trait attribute when the whole function is for a specific version.

@tjoubert tjoubert mentioned this pull request Oct 17, 2022
Closed
@DiscoPYF DiscoPYF linked an issue Oct 17, 2022 that may be closed by this pull request
Run tests against ArangoDB 3.10 #428
Closed
@DiscoPYF
Copy link
Collaborator

I've added support for version numbers to all test fixture classes. I think it gives us a bit more control on version-specific processing than the Trait attribute does. What do you think @DiscoPYF? That said, I think it's good we keep both in place; we'll use if statements to check version numbers within functions and the Trait attribute when the whole function is for a specific version.

Sounds good to me 👍

@tjoubert tjoubert merged commit 62381b9 into master Oct 17, 2022
@tjoubert tjoubert deleted the test-arangodb-3_10 branch October 17, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiscoPYF DiscoPYF Awaiting requested review from DiscoPYF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests against ArangoDB 3.10
2 participants
@tjoubert @DiscoPYF