Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded sample app #596

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Upgraded sample app #596

wants to merge 6 commits into from

Conversation

terryyoon-pdftron
Copy link
Contributor

@terryyoon-pdftron terryyoon-pdftron commented Aug 19, 2022

NSDK-168

Overview:

This PR replaces the sample app in the example folder with a more comprehensive app instead of a standalone PDF viewer in order to better demonstrate how the wrapper can be embedded in an existing app and how its API can be used.

The app is a simple file manager within the app's folder with the ability to add files from the device's local storage or from the web, plus other miscellaneous functionalities. It uses this package for opening PDF files and for converting Office files to PDF.

The app is built using Expo SDK 46 with bare workflow (ejected) and React Native version 0.69.4.

Relevant changes are in the file App.tsx and the files under the components directory (other changes are due to React Native version changes and using Expo). Testing future changes can now be done by modifying the PDFViewer.tsx file instead of App.js.

Testing:

  • Checkout this branch in the outer repo.
  • Delete node_modules, and run yarn install
  • Within node_modules, delete react-native-pdftron, clone this repo and re-name it to react-native-pdftron.
  • Run the app:
    • iOS: yarn ios
    • Android: yarn android

@sgong-pdftron
Copy link
Contributor

@darrenchann could you please perform first round of review, thanks.

Copy link
Contributor

@darrenchann darrenchann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS: needs the similar changes done by @dluco to fix folder structure and library dependency issues found when running app
https://github.com/PDFTron/react-native-sample/pull/23/commits

Android:
runs fine

@sgong-pdftron sgong-pdftron marked this pull request as draft March 1, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants