Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add box.linters styling functions. add check for treesitter dependencies #607

Merged
merged 19 commits into from
Sep 5, 2024

Conversation

radbasa
Copy link
Contributor

@radbasa radbasa commented Aug 5, 2024

Have you read the Contributing Guidelines?

Issue #606

Description

  • Adds box::use styling to format_r()
  • Adds documentation for box::use styling

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

DESCRIPTION Outdated Show resolved Hide resolved
R/tools.R Outdated Show resolved Hide resolved
R/tools.R Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@radbasa
Copy link
Contributor Author

radbasa commented Aug 21, 2024

@jakubnowicki Will need to go back to box.linters::style_*.

0.10.2 converts:

# View: Shiny modules and related code.
# https://go.appsilon.com/rhino-project-structure

to

NA
NA

R/tools.R Show resolved Hide resolved
@radbasa radbasa marked this pull request as ready for review August 21, 2024 10:25
R/dependencies.R Outdated Show resolved Hide resolved
R/tools.R Outdated Show resolved Hide resolved
@radbasa radbasa mentioned this pull request Sep 3, 2024
3 tasks
R/tools.R Outdated Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
R/tools.R Outdated Show resolved Hide resolved
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please resolve my comment and you can merge.

R/tools.R Outdated Show resolved Hide resolved
@radbasa radbasa merged commit 0cc7b57 into main Sep 5, 2024
10 checks passed
@radbasa radbasa deleted the integrate-box-linters-styling branch September 5, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants