Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in documentation #49

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Fix example in documentation #49

merged 3 commits into from
Dec 11, 2023

Conversation

jakubnowicki
Copy link
Member

@jakubnowicki jakubnowicki commented Dec 8, 2023 •
edited
Loading

Have you read the Contributing Guidelines?

Issue #45

Changes description

  • Remove incorrect parameter from server-side example.
  • Fix documentation page styling.
  • Add changelog to the documentation page.

@jakubnowicki jakubnowicki requested a review from vibalre December 8, 2023 10:08
vibalre
vibalre approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@vibalre vibalre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested example locally, confirming that it works.

@jakubnowicki jakubnowicki merged commit 8dc8efc into main Dec 11, 2023
6 checks passed
@jakubnowicki jakubnowicki deleted the fix-example-in-documentation branch December 11, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vibalre vibalre vibalre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubnowicki @vibalre