Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/klmr box support #9

Merged
merged 7 commits into from
Jan 20, 2023
Merged

Feature/klmr box support #9

merged 7 commits into from
Jan 20, 2023

Conversation

radbasa
Copy link
Collaborator

@radbasa radbasa commented Jan 19, 2023

Issue #2

Test coverage works with basic box module loading.

box::use(
  app/module
)
  • Unit tests provided
  • To use with a rhino app, covr::file_coverage(source_files = "app/main.R", test_files = list.files("test/testthat", full.names = TRUE))
  • To get the GUI report, covr::report(covr::file_coverage(source_files = "app/main.R", test_files = list.files("tests/testthat", full.names = TRUE)))

@radbasa radbasa self-assigned this Jan 19, 2023
@radbasa radbasa linked an issue Jan 19, 2023 that may be closed by this pull request
Make covr work with a basic box module #2
Closed
jakubnowicki
jakubnowicki approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

DESCRIPTION Outdated Show resolved Hide resolved
tests/testthat/test-box.R Outdated Show resolved Hide resolved
radbasa and others added 2 commits January 20, 2023 12:24
@radbasa @jakubnowicki
Forgot an s
7d4a35a 
Co-authored-by: Jakub Nowicki <[email protected]>
@radbasa @jakubnowicki
Smaller version increment as suggested
d1f485c 
Co-authored-by: Jakub Nowicki <[email protected]>
@radbasa radbasa merged commit 4212ad1 into develop Jan 20, 2023
@radbasa radbasa deleted the feature/klmr-box-support branch January 20, 2023 04:26
@radbasa radbasa mentioned this pull request Jan 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees

@radbasa radbasa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make covr work with a basic box module
2 participants
@radbasa @jakubnowicki