Simplified the kafka integration tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evg-tso
force-pushed
the
use-test-containers
branch
from
b532c06
to
863716f
Compare
- Using `testcontainers` instead of `org.apache.kafka/kafka_2.12`, to spin a Kafka dind container. This simplified the Kafka cluster startup and leaves the configuration to the battle tested `testcontainers`.
evg-tso
force-pushed
the
use-test-containers
branch
from
863716f
to
6746fe9
Compare
|
@yonatane , should this PR be into |
No, that's fine. |
- Also upgrade to the latest clj-test-containers version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testcontainersinstead oforg.apache.kafka/kafka_2.12, to spin a Kafka dind container. This simplified the Kafka cluster startup and leaves the configuration to the battle testedtestcontainers.