Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consumer shutdown #14

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Fix consumer shutdown #14

merged 3 commits into from
Jan 3, 2023

Conversation

asafch
Copy link
Contributor

@asafch asafch commented Nov 28, 2022

Changed

  • Cemented a couple of dev dependencies to stop crashing because of :pedantic?
  • The source's polling loop would run forever because a vector is a truthy value. Instead, it should deref the volatile inside the vector

evg-tso
evg-tso approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@evg-tso evg-tso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdrdannyr mdrdannyr merged commit 690e1f5 into AppsFlyer:master Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Unit Test Results

  1 files  ±0  11 suites  ±0   0s ⏱️ ±0s
23 tests ±0  23 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 690e1f5. ± Comparison against base commit 690e1f5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evg-tso evg-tso evg-tso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asafch @evg-tso @mdrdannyr @yonatane