Fix #8329: StorageService updates getting more expensive over time #8331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
added a commit
that referenced
this pull request
Jan 14, 2025
…8331) Fixes #8329 which was caused by the inner maps of `cachedAvailableStacks` never getting removed: once the primary key of an AEKey would have been observed in the network, it would never get removed from the cached stacks. This causes performance to degrade over time if many different items are transiting through the network. The fix is simply the extra `removeEmptySubmaps` call. In this PR, I also removed the backbuffer because it looks pointless in the way it is currently implemented.
Technici4n
added a commit
that referenced
this pull request
Jan 14, 2025
…8331) Fixes #8329 which was caused by the inner maps of `cachedAvailableStacks` never getting removed: once the primary key of an AEKey would have been observed in the network, it would never get removed from the cached stacks. This causes performance to degrade over time if many different items are transiting through the network. The fix is simply the extra `removeEmptySubmaps` call. In this PR, I also removed the backbuffer because it looks pointless in the way it is currently implemented.
nk2IsHere
pushed a commit
to nk2IsHere/Franken-AE2
that referenced
this pull request
Jan 16, 2025
…nsive over time (AppliedEnergistics#8331) Fixes AppliedEnergistics#8329 which was caused by the inner maps of `cachedAvailableStacks` never getting removed: once the primary key of an AEKey would have been observed in the network, it would never get removed from the cached stacks. This causes performance to degrade over time if many different items are transiting through the network. The fix is simply the extra `removeEmptySubmaps` call. In this PR, I also removed the backbuffer because it looks pointless in the way it is currently implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8329 which was caused by the inner maps of
cachedAvailableStacksnever getting removed: once the primary key of an AEKey would have been observed in the network, it would never get removed from the cached stacks. This causes performance to degrade over time if many different items are transiting through the network.The fix is simply the extra
removeEmptySubmapscall. In this PR, I also removed the backbuffer because it looks pointless in the way it is currently implemented.