Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Craft Progress, fluid using 1 Bucket = 81000 Items. #7321

Closed
Simba98 opened this issue Aug 7, 2023 · 1 comment · Fixed by #8266
Closed

Incorrect Craft Progress, fluid using 1 Bucket = 81000 Items. #7321

Simba98 opened this issue Aug 7, 2023 · 1 comment · Fixed by #8266
Labels
bug Self explanatory?

Comments

@Simba98
Copy link
Contributor

Simba98 commented Aug 7, 2023

Describe the bug

When I use the wireless terminal to view cpu progress, the number shows even larger than the bytes of the cpu.

After looking the source code, this is due to one bucket = 81k items.

But the setting makes the progress meaningless, because the fluid will dominant the progress.

For some case, it use 1 bucket = 81k item.

image
image

How to reproduce the bug

Make fluid as output

Expected behavior

Maybe use 1bucket = 1item to balance.

Additional details

No response

Which minecraft version are you using?

1.19

On which mod loaders does it happen?

Fabric

Crash log

NA
@Simba98 Simba98 added the bug Self explanatory? label Aug 7, 2023
@Simba98 Simba98 changed the title Progress item number incorrect Incorrect Craft Progress, fluid using 1 Bucket = 81000 Items. Aug 7, 2023
@Simba98
Copy link
Contributor Author

Simba98 commented Aug 7, 2023

I guess this is due to

Applied-Energistics-2/src/main/java/appeng/crafting/execution/ExecutingCraftingJob.java

Line 81 in 172a36d

totalPending += output.amount() * entry.getValue();

cplir-c added a commit to cplir-c/Applied-Energistics-2 that referenced this issue Jul 18, 2024
@cplir-c
Replace raw long counting with a Long2LongMap accumulator
920830e 
Attempts to fix fluid using 1 Bucket = 81k items: AppliedEnergistics#7321
I chose to use a Long2LongMap accumulator so that different AEKeyTypes
	with the same denominator could be summed in the same map slot,
	and avoid the internal-rounding issues that would be had if I
	divided all the values by their Unit denominators.
@cplir-c cplir-c mentioned this issue Jul 18, 2024
Closed
@Simba98 Simba98 mentioned this issue Aug 27, 2024
Closed
@shartte shartte mentioned this issue Dec 7, 2024
Merged
@shartte shartte closed this as completed in 5759cb7 Dec 7, 2024
shartte added a commit that referenced this issue Dec 7, 2024
@shartte
Normalized crafting progress across items/fluids/etc. (#8266)
aa8e68f 
Fixes #7321, and replace
#8045.

Normalizes the progress of each key type to their "unit" amount (i.e. 1
bucket for fluid) and shows progress in percent.

---------

Co-authored-by: Simba98 <[email protected]>

(cherry picked from commit 5759cb7)
shartte added a commit that referenced this issue Dec 8, 2024
@shartte
Normalized crafting progress across items/fluids/etc. (#8266)
6f86ce0 
Fixes #7321, and replace
#8045.

Normalizes the progress of each key type to their "unit" amount (i.e. 1
bucket for fluid) and shows progress in percent.

---------

Co-authored-by: Simba98 <[email protected]>

(cherry picked from commit 5759cb7)
(cherry picked from commit aa8e68f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Self explanatory?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalized crafting progress across items/fluids/etc. AppliedEnergistics/Applied-Energistics-2
1 participant
@Simba98