-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abnormal behavior of Pattern Provider in "lock crafting until redstone pulse is received" mode #7179
Comments
Hello, |
With this change pattern providers will check if they already have a redstone signal when locking, and if so they will wait for the signal to depower and then power again. This fixes odd behavior with a constant redstone signal and block updates leading to unlocking without a 'pulse'. ![2024-08-28_17 50 27](https://github.com/user-attachments/assets/f9725586-6202-42b8-bd6c-71414059f551) Fixes #7179 --------- Co-authored-by: Sebastian Hartte <[email protected]>
With this change pattern providers will check if they already have a redstone signal when locking, and if so they will wait for the signal to depower and then power again. This fixes odd behavior with a constant redstone signal and block updates leading to unlocking without a 'pulse'. ![2024-08-28_17 50 27](https://github.com/user-attachments/assets/f9725586-6202-42b8-bd6c-71414059f551) Fixes #7179 --------- Co-authored-by: Sebastian Hartte <[email protected]> (cherry picked from commit a1211bc)
With this change pattern providers will check if they already have a redstone signal when locking, and if so they will wait for the signal to depower and then power again. This fixes odd behavior with a constant redstone signal and block updates leading to unlocking without a 'pulse'. ![2024-08-28_17 50 27](https://github.com/user-attachments/assets/f9725586-6202-42b8-bd6c-71414059f551) Fixes #7179 --------- Co-authored-by: Sebastian Hartte <[email protected]> (cherry picked from commit a1211bc) (cherry picked from commit 7de2565)
Describe the bug
Pattern Provider's "Lock crafting until redstone pulse is received" mode is behaving oddly. Expected behavior is to output one recipe then lock and only output the next recipe after a redstone pulse is received (as it does when you begin a crafting job with this setting enabled). My limited testing indicates that the length and side of the redstone leading into it can allow the Provider to output a recipe on both the rising edge and falling edge of the input redstone signal.
The sidedness comes into play in that it seems to take a shorter length of redstone dust to enable this behavior on some sides. In the example, the erroneous behavior only manifests after making a redstone line of length 4 to the north, but only a length of 2 to the east. Behavior is apparent with both buttons and levers. The rising/falling edge behavior is more apparent with a lever. The Pattern Provider unlocks and outputs a recipe and then locks again (as expected) when the lever is first powered on, but (when the lever is sufficiently far away) it also unlocks and outputs a recipe and then locks again when the lever is powered off.
https://streamable.com/c3bsfg (I'm looking at the item quantity changing at the top of my screen when hovering over the chest after pressing the button/lever instead of opening the chest every time to check its contents)
How to reproduce the bug
It should be noted that this does not appear to be a matter of redstone power level at the Provider. Placing the button or lever on a block above the redstone dust line leading into the Provider and extending redstone dust away from the Provider shows the same effect, even though the source of the redstone signal doesn't move and the power level (15) going into the Provider never changes when doing it this way.
The behavior is also present when a Redstone Repeater is powering the Provider.
Expected behavior
No matter the distance, side, or configuration for providing a redstone pulse to the Pattern Provider, I expect that the Provider will always allow a single recipe in per pulse (no matter the length of the pulse).
Additional details
v12.9.4 in the Valhelsia 5 modpack (5.0.18a)
Which minecraft version are you using?
1.19
On which mod loaders does it happen?
Forge
Crash log
NA but here's the mod list: https://pastebin.com/YbjvRtg3
The text was updated successfully, but these errors were encountered: