Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated progress indicator to AwesomeCameraPreview #408

Open
wants to merge 1 commit into
base: fix/release-1.4.0
Choose a base branch
from

Conversation

sopagna
Copy link

@sopagna sopagna commented Nov 13, 2023

Description

This pull request fixes the issue which the custom progress indicator is not pass down to the camera preview widget.
This results in inconsistent progress indicator loading screen, right before the actual camera preview is opened.

How to reproduce:

  1. Create a fullscreen black progress indicator widget
  2. Set the widget for progressIndicator property

Checklist

Before creating any Pull Request, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).

  • 📕 I read the Contributing page.
  • 🤝 I match the actual coding style.
  • ✅ I ran flutter analyze without any issues.

Breaking Change

  • 🛠 My feature contain breaking change.

If your feature break something, please detail it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant