Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let WordPress core handle .pot language file location #12

Closed
cowgill opened this issue Aug 11, 2016 · 5 comments
Closed

Let WordPress core handle .pot language file location #12

cowgill opened this issue Aug 11, 2016 · 5 comments
Assignees
Milestone

Comments

@cowgill
Copy link
Member

cowgill commented Aug 11, 2016

We no longer need to declare the .pot locale nor use load_textdomain();. WordPress core does this automatically in wp-admin/includes/plugin.php.

Instead, just add the Domain Path: to the plugin's header file as noted on the WordPress Developer Intl page.

Domain Path: /languages

@cowgill cowgill self-assigned this Aug 11, 2016
@cowgill cowgill added this to the 1.4.0 milestone Aug 11, 2016
cowgill added a commit that referenced this issue Aug 11, 2016
@meloniq meloniq reopened this Aug 11, 2016
@cowgill
Copy link
Member Author

cowgill commented Aug 12, 2016

@meloniq was correct. After doing some testing, the load_textdomain() and load_plugin_textdomain() code is still required. I've enhanced it further and will write up so documentation on best practices for all our products.

@meloniq
Copy link
Member

meloniq commented Aug 13, 2016

wp_20160813_12_28_38_pro

From prelection on WCMSK :) - but only for projects stored on WP.org

@cowgill
Copy link
Member Author

cowgill commented Aug 16, 2016

@meloniq, your image didn't upload.

@meloniq
Copy link
Member

meloniq commented Aug 17, 2016

@cowgill I have edited my comment above, image uploaded :)

@cowgill
Copy link
Member Author

cowgill commented Aug 18, 2016

@meloniq thanks. That's good news so eventually we can remove that extra code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants