[WIP] test: filter calculations #6530
Open
+650
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazin
force-pushed
the
test/filter-calculations
branch
from
0c9c4e2
to
79c186f
Compare
LucasXu0
reviewed
Oct 15, 2024
| children: [ | ||
| if (calculation != null) | ||
| RemoveCalculationButton( | ||
| onTap: () => context.read<CalculationsBloc>().add( |
There was a problem hiding this comment.
Move these onTap callbacks into new functions.
| expect(find.text('100'), findsNWidgets(2)); | ||
| }); | ||
|
|
||
| // TODO: Uncmoment expects |
|
This will be merged before 0.7.2 release, but requires another PR/changes to fix the filter bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that needs to be resolved, the regression test has been added but with the expects commented out at the moment.
PR Checklist