feat: make appflowy-cloud migrate use feature flags #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how we're running appflowy migrations. It basically provides a custom migration source capable of providing alternative migration sub-directories to be included/excluded in migration process. These can be used for conditional features like AI search/indexing and are execute in their order to creation.
It only affects migrations run by appflowy-cloud start process, and NOT by
sqlx migrateCLI command. To do that we would need to send PR to sqlx itself.It also introduces an
aifeature flag that can is used for conditional inclusion of search feature. (probably will need to change the name to something likevector-search).