Tweak AppVeyor build numbering to avoid failed builds #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
#737 PR builds fails on second Appveyor build, for merge-commit
Details on the issue fix or feature implementation
Amend cake script to use an AppVeyor build number based on the commit sha, when not on the
masterbranch; this will be different for the HEAD of branch and merge-commit.When on the
masterbranch, continue to use AppVeyor build numbers following the currentFullSemVerlabel, as this is the label used when auto-tagging releasesConfirm the following
I have included unit tests for the issue/feature