Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Context versus state #1847

Merged

Conversation

peter-csala
Copy link
Contributor

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

  • Added a subsection to the pipeline doc to clarify the difference between state and context objects
  • Refactored the ExecuteCoreSync for better legibility
    • I had to read this line many times to understand what's happening here:
    • var result = state.callback(context, state.state);

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@peter-csala
Copy link
Contributor Author

cc: @martintmk

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bb4764) 84.59% compared to head (1d37cb1) 84.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
- Coverage   84.59%   84.58%   -0.01%     
==========================================
  Files         308      308              
  Lines        6802     6798       -4     
  Branches     1049     1049              
==========================================
- Hits         5754     5750       -4     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.58% <100.00%> (-0.01%) ⬇️
macos 84.58% <100.00%> (-0.01%) ⬇️
windows 84.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/pipelines/index.md Outdated Show resolved Hide resolved
docs/pipelines/index.md Outdated Show resolved Hide resolved
docs/pipelines/index.md Outdated Show resolved Hide resolved
docs/pipelines/index.md Outdated Show resolved Hide resolved
docs/pipelines/index.md Outdated Show resolved Hide resolved
@martincostello martincostello merged commit 923063b into App-vNext:main Dec 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants