Bump the xunit group with 1 update #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the xunit group with 1 update: [xunit](https://github.com/xunit/xunit). - [Commits](xunit/xunit@2.5.3...2.6.0) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-minor dependency-group: xunit ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
.NET
![polly-reviewer-bot[bot]](https://avatars.githubusercontent.com/u/9165070?s=60&v=4){kind=small}
Fix CS0121 errors caused by ambiguity between `Task` and `ValueTask`.
martincostello
approved these changes
Nov 2, 2023
Fix compiler errors again by forcing the Func<Task> overload to be used.
Suppress xUnit1031 warnings that are OK because we explicitly want to wait for the operation to not succeed.
Rename method and drop type argument.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1769 +/- ##
=======================================
Coverage 84.53% 84.53%
=======================================
Files 307 307
Lines 6777 6777
Branches 1043 1043
=======================================
Hits 5729 5729
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Comment on lines
+108
to
+117
| // xunit 2.6.0 has Func<ValueTask> and Func<Task> overloads that cause ambiguity which | ||
| // is messy to resolve for multiple different TFMs, so force the Task version to be used. | ||
| static async Task AssertThrowsObjectDisposedExceptionAsync(Func<Task> func) | ||
| => await Assert.ThrowsAsync<ObjectDisposedException>(func); | ||
|
|
||
| await AssertThrowsObjectDisposedExceptionAsync(async () => await controller.CloseCircuitAsync(ResilienceContextPool.Shared.Get())); | ||
| await AssertThrowsObjectDisposedExceptionAsync(async () => await controller.IsolateCircuitAsync(ResilienceContextPool.Shared.Get())); | ||
| await AssertThrowsObjectDisposedExceptionAsync(async () => await controller.OnActionPreExecuteAsync(ResilienceContextPool.Shared.Get())); | ||
| await AssertThrowsObjectDisposedExceptionAsync(async () => await controller.OnActionSuccessAsync(Outcome.FromResult(10), ResilienceContextPool.Shared.Get())); | ||
| await AssertThrowsObjectDisposedExceptionAsync(async () => await controller.OnActionFailureAsync(Outcome.FromResult(10), ResilienceContextPool.Shared.Get())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the xunit group with 1 update: xunit.
Commits
6a07b95v2.6.05a7297e#2806: Performance improvements in Assert.Equal (v2)a6b5cc4Add net6.0 binary to xunit.assertabc1dd3Update Microsoft.NETCore.App.Ref to 6.052b6638Move CA1304 and CA1305 enablement to production code only (not test code)e139d77Ensure all throws of NotImplementedException contain messages8a84fdbEnsure all GetHashCode functions are implemented (#2804) (v2)c853205Unit tests for #2803 (v2)8ffe56aUnit tests for #2800 (v2)b2e660eReplace (most) concatenation and interpolation (in shipped code) with String....Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions